Re: contrib/pg_buffercache - Mailing list pgsql-hackers

From Mark Kirkwood
Subject Re: contrib/pg_buffercache
Date
Msg-id 4238F11E.2090405@paradise.net.nz
Whole thread Raw
In response to Re: contrib/pg_buffercache  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan wrote:
> 
> Mark Kirkwood wrote:
> 
> 
>>Andrew Dunstan wrote:
>>
>>
>>>It fixes the build error on Windows - haven't tried because i don't have
>>>time, but I know it won't work on Cygwin, because WIN32 isn't (usually)
>>>defined on Cygwin - see previous almost endless discussions.
>>>
>>
>>Yes - I recall that discussion a while ago.
>>
>>This patch should sort the issue.
>>
>>One question, should I be using defined(__MINGW32__) as opposed to
>>defined(WIN32)? I figured I didn't as in this case it is not necessary
>>to distinguish between native and cygwin.
>>
>>
> 
> 
> You figured correctly.
> 

Oh, and thanks to your efforts with the automated build system this gets 
picked up now instead of lurking till after release - great work!

cheers

Mark



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: contrib/pg_buffercache
Next
From: Tom Lane
Date:
Subject: Re: read-only database