Re: [HACKERS] contrib/pg_buffercache

From: Andrew Dunstan
Subject: Re: [HACKERS] contrib/pg_buffercache
Date: ,
Msg-id: 4238DB4A.6010500@dunslane.net
(view: Whole thread, Raw)
In response to: Re: [HACKERS] contrib/pg_buffercache  (Mark Kirkwood)
List: pgsql-patches


Mark Kirkwood wrote:

> Andrew Dunstan wrote:
>
>> It fixes the build error on Windows - haven't tried because i don't have
>> time, but I know it won't work on Cygwin, because WIN32 isn't (usually)
>> defined on Cygwin - see previous almost endless discussions.
>>
>
> Yes - I recall that discussion a while ago.
>
> This patch should sort the issue.
>
> One question, should I be using defined(__MINGW32__) as opposed to
> defined(WIN32)? I figured I didn't as in this case it is not necessary
> to distinguish between native and cygwin.
>
>

You figured correctly.

cheers

andrew


pgsql-patches by date:

From: Andrew Dunstan
Date:
Subject: Re: [HACKERS] contrib/pg_buffercache
From: Neil Conway
Date:
Subject: refactor preprocess_targetlist