Re: error report on slru.c - Mailing list pgsql-patches

From Gaetano Mendola
Subject Re: error report on slru.c
Date
Msg-id 415FF3A0.3090304@bigfoot.com
Whole thread Raw
In response to Re: error report on slru.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:
> Gaetano Mendola <mendola@bigfoot.com> writes:
>
>>here a patch that
>>1) Rise the information about the file missing on pg_clog from
>>    detail to error
>
>
> This violates the message style guidelines, IMHO.

Tom, your opinion is not humble but is is really appreciated, however
I think that a missing file is not a "detail" information.

>>2) Insert the offset information also for a missing file
>
>
> It's hardly necessary, since the transaction number tells you everything
> you need to know if you really need it, and the offset is certainly not
> relevant to a file-open failure.

Good to know, how is possible then retrive the informations about the file
needed and the offset without rise the logs detail ?


Regards
Gaetano Mendola










pgsql-patches by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: [PATCH] 5 plperl patches
Next
From: Neil Conway
Date:
Subject: license cleanup