Re: error report on slru.c - Mailing list pgsql-patches

From Tom Lane
Subject Re: error report on slru.c
Date
Msg-id 26994.1096759424@sss.pgh.pa.us
Whole thread Raw
In response to error report on slru.c  (Gaetano Mendola <mendola@bigfoot.com>)
Responses Re: error report on slru.c  (Gaetano Mendola <mendola@bigfoot.com>)
Re: error report on slru.c  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-patches
Gaetano Mendola <mendola@bigfoot.com> writes:
> here a patch that
> 1) Rise the information about the file missing on pg_clog from
>     detail to error

This violates the message style guidelines, IMHO.

> 2) Insert the offset information also for a missing file

It's hardly necessary, since the transaction number tells you everything
you need to know if you really need it, and the offset is certainly not
relevant to a file-open failure.

            regards, tom lane

pgsql-patches by date:

Previous
From: Reini Urban
Date:
Subject: Re: LDFLAGS overriding
Next
From: Tom Lane
Date:
Subject: Re: LDFLAGS overriding