>>It's not a problem, since that code path is only ever executed when
>>dumping a 7.0 backend. It's in the MyFormatType function in pg_dump.c
>>that is used whenever the backend doesn't have its own format_type function.
>
> Right. The patch looked dangerous to me too, until I understood the
> context. As-is, I think it's fine -- indeed, I think we ought to
> backpatch it into 7.4 branch too.
Strangely enough, the 7.0.x pg_dump.c does just dump arrays as bpchar_
type, but the 7.0.x psql utility displays them as character varying[]
Chris
