Re: Result Set Cursor Patch - Mailing list pgsql-jdbc

From Oliver Jowett
Subject Re: Result Set Cursor Patch
Date
Msg-id 40997391.20301@opencloud.com
Whole thread Raw
In response to Re: Result Set Cursor Patch  (Kris Jurka <books@ejurka.com>)
Responses Re: Result Set Cursor Patch
Re: Result Set Cursor Patch
List pgsql-jdbc
Kris Jurka wrote:

> The formatting is an issue.  Yes, the code is formatted differently all
> over the driver, but now is not the time to fix that.  There are too many
> outstanding patches that will conflict with these whitespace changes to
> try and do something about that now.  I aim to reindent/reformat at the
> start of 7.5 beta when there shouldn't be many outstanding patches or
> active development.

Are we still tracking the main tree's release cycle then? I thought part
of the reason for moving to gborg was because the JDBC driver's release
cycle didn't match the main tree's release cycle well?

I have a large stack of not-yet-ready-for-prime-time v3 protocol changes
that I'd like to get in at some point -- but I don't want to get bitten
by "we're in beta, this is too big to apply". Are we planning on a
code/feature freeze or similar, tracking whatever 7.5 is doing?

Also, now that the driver is separate from the main code tree, maybe
it'd be a good idea when reindenting to use more "normal" (for java
anyway) indentation rules -- e.g. use either all spaces or spaces and
8-character tabs when indenting. The current 4-character tabs rule is
fairly unusual. That'd make driver editing easier across a range of
IDEs; sure, I have my xemacs settings that play nicely with the current
scheme, but it's a barrier to entry for anyone who hasn't worked on the
driver before.

-O

pgsql-jdbc by date:

Previous
From: Andy Zeneski
Date:
Subject: Re: Result Set Cursor Patch
Next
From: Oliver Jowett
Date:
Subject: V3 extended query protocol and type problems