Re: Updated COPY CSV patch - Mailing list pgsql-patches

From Andrew Dunstan
Subject Re: Updated COPY CSV patch
Date
Msg-id 407C2EDC.8080808@dunslane.net
Whole thread Raw
In response to Re: Updated COPY CSV patch  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Updated COPY CSV patch
List pgsql-patches
Bruce Momjian wrote:

>Andrew Dunstan wrote:
>
>
>>Bruce Momjian wrote:
>>
>>
>>
>>>While doing OIDs seems atypical, it seems like a reasonable thing that
>>>CSV should be able to do.  Basically, I see no reason to disable it.
>>>
>>>
>>>
>>>
>>>
>>OK. We have bigger fish to fry ;-)
>>
>>
>
>Uh, sorry, what I meant was that we should have it working in this
>patch.  No reason to leave it for later.  We have to get this 100% right
>the first time because people will start relying on it.
>
>
>

Yes. What *I* meant was that allowing it was OK with me, and not worth
arguing over.

Incidentally, the patch looks OK at first glance, and seems to work
fine, modulo today's little controversies, with this exception:

    if (csv_mode)
    {
        if (!quote)
            quote = "\"";
        if (!escape)
            escape = "\""; /* should be "escape = quote;" */
    }


cheers

andrew

pgsql-patches by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Updated COPY CSV patch
Next
From: Bruce Momjian
Date:
Subject: Re: Updated COPY CSV patch