Re: Updated COPY CSV patch - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Updated COPY CSV patch
Date
Msg-id 200404131848.i3DImhM05852@candle.pha.pa.us
Whole thread Raw
In response to Re: Updated COPY CSV patch  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-patches
Andrew Dunstan wrote:
> Yes. What *I* meant was that allowing it was OK with me, and not worth
> arguing over.

OK, thanks.

> Incidentally, the patch looks OK at first glance, and seems to work
> fine, modulo today's little controversies, with this exception:
>
>     if (csv_mode)
>     {
>         if (!quote)
>             quote = "\"";
>         if (!escape)
>             escape = "\""; /* should be "escape = quote;" */
>     }

Oh, excellent point.

On my other WITH NULL ALL|STRICT|NONE email, we could have '' be ALL and
have it be WITH NULL ''|STRICT|NONE.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Updated COPY CSV patch
Next
From: Tom Lane
Date:
Subject: Re: Updated COPY CSV patch