Re: Unportable use of uname in pg_upgrade test script - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Unportable use of uname in pg_upgrade test script
Date
Msg-id 4017.1348940787@sss.pgh.pa.us
Whole thread Raw
In response to Re: Unportable use of uname in pg_upgrade test script  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> Exactly, the sed script pulls the last token from the line, which is 
> Msys on all my Mingw systems.

Perhaps that's "uname -v"?

> If you want to do it another way we could possibly pass the PORTNAME 
> from the global make file.

That might be safer.  The last few words of uname's output are
*completely* unstandardized (the spec says that implementation-defined
fields can be added to -a's output ...)
        regards, tom lane








































































> cheers

> andrew



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Unportable use of uname in pg_upgrade test script
Next
From: Andrew Dunstan
Date:
Subject: Re: pg_upgrade tests vs alter generic changes