Re: Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line - Mailing list pgsql-hackers

From David Steele
Subject Re: Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line
Date
Msg-id 3a16b540-0e4a-ceb3-4091-171a57600756@pgmasters.net
Whole thread Raw
In response to Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line  (Andrey Borodin <x4mmm@yandex-team.ru>)
Responses Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line
List pgsql-hackers
On 3/6/19 5:38 PM, Andrey Borodin wrote:
>> 20 февр. 2019 г., в 17:06, Alexey Kondratov <a.kondratov@postgrespro.ru> написал(а):
> 
> The new patch is much smaller (less than 400 lines) and works as advertised.
> There's a typo "retreive" there.
> 
> These lines look a little suspicious:
>         char  postgres_exec_path[MAXPGPATH],
>                   postgres_cmd[MAXPGPATH],
>                   cmd_output[MAX_RESTORE_COMMAND];
> Is it supposed to be any difference between MAXPGPATH and MAX_RESTORE_COMMAND?
> 
> Besides this, patch looks fine to me.

This patch appears to need attention from the author so I have marked it 
Waiting on Author.

Regards,
-- 
-David
david@pgmasters.net


pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Making all nbtree entries unique by having heap TIDs participatein comparisons
Next
From: Michael Paquier
Date:
Subject: Re: pg_basebackup against older server versions