Re: Inconsistent printf placeholders - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Inconsistent printf placeholders
Date
Msg-id 3F7ECE6B-B9E8-4E7D-A3DF-C20F5433C4B2@yesql.se
Whole thread Raw
In response to Inconsistent printf placeholders  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-hackers
> On 14 Mar 2024, at 05:20, Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote:

> I'd be happy if the two messages kept consistency. I suggest aligning
> types instead of making the messages different, as attached.

I've only skimmed this so far but +1 on keeping the messages the same where
possible to reduce translation work.  Adding a comment on the message where the
casting is done to indicate that it is for translation might reduce the risk of
it "getting fixed" down the line.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: BitmapHeapScan streaming read user and prelim refactoring
Next
From: Heikki Linnakangas
Date:
Subject: Re: Flushing large data immediately in pqcomm