Inconsistent printf placeholders - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject Inconsistent printf placeholders
Date
Msg-id 20240314.132041.2150305296896280760.horikyota.ntt@gmail.com
Whole thread Raw
Responses Re: Inconsistent printf placeholders
Re: Inconsistent printf placeholders
List pgsql-hackers
Hello.

A recent commit 6612185883 introduced two error messages that are
identical in text but differ in their placeholders.

-            pg_fatal("could not read file \"%s\": read only %d of %d bytes",
-                     filename, (int) rb, (int) st.st_size);
+            pg_fatal("could not read file \"%s\": read only %zd of %lld bytes",
+                     filename, rb, (long long int) st.st_size);
...
-            pg_fatal("could not read file \"%s\": read only %d of %d bytes",
+            pg_fatal("could not read file \"%s\": read only %d of %u bytes",
                      rf->filename, rb, length);

I'd be happy if the two messages kept consistency. I suggest aligning
types instead of making the messages different, as attached.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Recent 027_streaming_regress.pl hangs
Next
From: Kyotaro Horiguchi
Date:
Subject: Typos in reorderbuffer.c.