Re: suspicous looking code in copy.c - Mailing list pgsql-hackers

From Andreas Pflug
Subject Re: suspicous looking code in copy.c
Date
Msg-id 3F4DF33B.6090503@pse-consulting.de
Whole thread Raw
In response to suspicous looking code in copy.c  (Dave Cramer <dave@fastcrypt.com>)
Responses Re: suspicous looking code in copy.c
Re: suspicous looking code in copy.c
List pgsql-hackers
Dave Cramer wrote:

>This just doesn't look right.
>
>line 364
>                case COPY_NEW_FE:
> 
>                      while (datasize > 0 && !fe_eof)
>             ....
>
>line 408        datasize =- avail;
>
>
>shouldn't it be datasize -= avail ?
>  
>
AFAIR this is a really outdated K&R style of -=  . Compilers *should* 
recognize this (and will throw an ambiguity error if there's no space 
after =- ), but it's better to use the 'newer' style.

Regards,
Andreas




pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Linux2.6 overcommit behaviour
Next
From: ohp@pyrenet.fr
Date:
Subject: Index creation takes for ever