Re: patch: tiny patch to correct stringbuffer size estimate - Mailing list pgsql-jdbc

From Fernando Nasser
Subject Re: patch: tiny patch to correct stringbuffer size estimate
Date
Msg-id 3F1D4BD1.2060600@redhat.com
Whole thread Raw
In response to patch: tiny patch to correct stringbuffer size estimate  (Oliver Jowett <oliver@opencloud.com>)
List pgsql-jdbc
This is already accounted for in the 10% that is added to it, isn't it?

Oliver Jowett wrote:
> This patch tweaks the size estimate when escaping strings to count the
> enclosing quotes.
>
> -O
>
>
> ------------------------------------------------------------------------
>
> Index: AbstractJdbc1Statement.java
> ===================================================================
> RCS file: /projects/cvsroot/pgsql-server/src/interfaces/jdbc/org/postgresql/jdbc1/AbstractJdbc1Statement.java,v
> retrieving revision 1.28
> diff -u -c -r1.28 AbstractJdbc1Statement.java
> *** AbstractJdbc1Statement.java    22 Jul 2003 05:17:09 -0000    1.28
> --- AbstractJdbc1Statement.java    22 Jul 2003 13:53:03 -0000
> ***************
> *** 1034,1040 ****
>               synchronized (sbuf)
>               {
>                   sbuf.setLength(0);
> !                 sbuf.ensureCapacity(x.length() + (int)(x.length() / 10));
>                   sbuf.append('\'');
>                   escapeString(x, sbuf);
>                   sbuf.append('\'');
> --- 1034,1040 ----
>               synchronized (sbuf)
>               {
>                   sbuf.setLength(0);
> !                 sbuf.ensureCapacity(2 + x.length() + (int)(x.length() / 10));
>                   sbuf.append('\'');
>                   escapeString(x, sbuf);
>                   sbuf.append('\'');
>
>
> ------------------------------------------------------------------------
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster


--
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9


pgsql-jdbc by date:

Previous
From: Fernando Nasser
Date:
Subject: Re: the IN clause saga
Next
From: Dmitry Tkach
Date:
Subject: Re: the IN clause saga