Re: JDBC commit to 7.1.2 - Mailing list pgsql-hackers

From Barry Lind
Subject Re: JDBC commit to 7.1.2
Date
Msg-id 3B0AB9B7.2030802@xythos.com
Whole thread Raw
In response to JDBC commit to 7.1.2  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: JDBC commit to 7.1.2  (Bruce Momjian <pgman@candle.pha.pa.us>)
Re: Re: JDBC commit to 7.1.2  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
The jdbc1 code does not have the problem that this patch corrects.  So
no it does not need to be and should not be applied to the jdbc1 area.

I also noticed that that the original patch which was for the
jdbc2/ResultSet.java file was also applied to the jdbc1/ResultSet.java
file on the main trunk of the CVS.  This will not work and that patch
needs to be removed from jdbc1/ResultSet.java. (The variable the patch
uses doesn't exist in the jdbc1 code thus the current jdbc1 code will
not compile).

The jdbc1 and jdbc2 sets of files are sufficiently different that
patches for one should not be applied to the other.

thanks,
--Barry

Bruce Momjian wrote:

> This timezone fix was applied to jdbc2 in 7.1.2 by Thomas.  Do you want
> this in jdbc1 also?  I am not recommending it, just asking to make sure
> it wasn't overlooked.
>
> ---------------------------------------------------------------------------
>
> revision 1.22.2.1
> date: 2001/05/22 14:46:46;  author: thomas;  state: Exp;  lines: +4 -4
> Patch from Barry Lind to correctly decode time zones in timestamp results.
>  Without patch, the time zone field is ignored and the returned time is
>  not correct.
>  Already applied to the development tree...
>


pgsql-hackers by date:

Previous
From: The Hermit Hacker
Date:
Subject: Re: Not released yet, but could someone take a quick peak ...
Next
From: Bruce Momjian
Date:
Subject: SEP_CHAR