Re: Comment for UserMappingPasswordRequired in contrib/postgres_fdw - Mailing list pgsql-hackers

From Andreas Karlsson
Subject Re: Comment for UserMappingPasswordRequired in contrib/postgres_fdw
Date
Msg-id 399150cb-a2ba-4405-a3d6-290d760b8d6c@proxel.se
Whole thread Raw
In response to Comment for UserMappingPasswordRequired in contrib/postgres_fdw  (Etsuro Fujita <etsuro.fujita@gmail.com>)
Responses Re: Comment for UserMappingPasswordRequired in contrib/postgres_fdw
List pgsql-hackers
On 2/18/26 9:23 PM, Etsuro Fujita wrote:
> I think the former part of the comment should be: Return *false* if
> the password_required is defined and false for this user mapping,
> otherwise *true*.
I feel the wording of the comment is pretty awkward both before and 
after your correctness fix. I am not a native speaker but shouldn't it 
be something like the below which explains better what is actually going on.

/*
  * Checks the value of password_required, defaults to true
  * if not defined. The mapping has been pre-validated.
  */

Andreas




pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: libpq: Bump protocol version to version 3.2 at least until the first/second beta
Next
From: Andres Freund
Date:
Subject: Re: convert SpinLock* macros to static inline functions