Re: Fwd: lwlocknames.h beautification attempt - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fwd: lwlocknames.h beautification attempt
Date
Msg-id 3932700.1742194712@sss.pgh.pa.us
Whole thread Raw
In response to Fwd: lwlocknames.h beautification attempt  (Gurjeet Singh <gurjeet@singh.im>)
List pgsql-hackers
Gurjeet Singh <gurjeet@singh.im> writes:
> On Sun, Mar 16, 2025 at 7:53 PM Robert Haas <robertmhaas@gmail.com> wrote:
>> I'm confused. Tom and I both said we didn't like this change,

> To me, Tom's feedback felt as being between ambivalent to the change and perhaps
> agree with the change, as long as pgindent did not throw a fit, which
> it did not.

Geez, are we really going to argue about whitespace in a generated
file?  But anyway, what I said was that I didn't like the style with
the define'd symbol right-justified, because it didn't look like
anything else in our code.  I'm entirely okay with the committed
version, which has plenty of precedent formatting-wise.

            regards, tom lane



pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
Next
From: Peter Eisentraut
Date:
Subject: Re: 64 bit numbers vs format strings