Re: pg_dump --with-* options - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: pg_dump --with-* options
Date
Msg-id 3860919f09b1edc31f5c19adb3260836afd3283c.camel@j-davis.com
Whole thread Raw
In response to Re: pg_dump --with-* options  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
On Fri, 2025-08-01 at 17:46 -0500, Nathan Bossart wrote:
> On Fri, Aug 01, 2025 at 12:42:16PM -0700, Jeff Davis wrote:
> > -      <term><option>--with-statistics</option></term>
> > +      <term><option>--statistics</option></term>
>
> > -      <term><option>--with-statistics</option></term>
> > +      <term><option>--statistics</option></term>
>
> > -      <term><option>--with-statistics</option></term>
> > +      <term><option>--statistics</option></term>
>
> nitpick: --statistics should be moved to maintain alphabetical
> ordering.
>

Thank you. I committed this and closed the Open Item.

I did not address the following issues:

  * Did not change default to on: there was no consensus on this point,
and the default-off opinions were stronger. We may be able to revisit
for PG19.
  * Did not add --include syntax: no patch and no consensus on the
details.
  * Did not remove redundant --no-statistics option for pg_dump and
redundant --statistics option for pg_restore: kept for consistency
between pg_dump and pg_restore, and to allow us to potentially change
to default-on in the future.

If someone feels one of these needs to be addressed in PG18, let me
know.

Regards,
    Jeff Davis




pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: pg_dump --with-* options
Next
From: Jeff Davis
Date:
Subject: Re: pg_dump --with-* options