Re: Testing the async-commit patch - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Testing the async-commit patch
Date
Msg-id 3812.1187108964@sss.pgh.pa.us
Whole thread Raw
In response to Re: Testing the async-commit patch  ("Simon Riggs" <simon@2ndquadrant.com>)
Responses Re: Testing the async-commit patch  ("Simon Riggs" <simon@2ndquadrant.com>)
Re: Testing the async-commit patch  ("Simon Riggs" <simon@2ndquadrant.com>)
List pgsql-hackers
"Simon Riggs" <simon@2ndquadrant.com> writes:
> On Tue, 2007-08-14 at 12:09 -0400, Tom Lane wrote:
>> heapam.c lines 1843-1852 presume previous xmax can be hinted
>> immediately, ditto lines 2167-2176, ditto lines 2716-2725.
>> I think probably we should just remove those lines --- they are only
>> trying to save work for future tqual.c calls.

> I'll check those out later tonight.

[ looks closer ] Actually, we can't just dike out those code sections,
because the immediately following code assumes that XMAX_INVALID is
correct.  So I guess we need to export HeapTupleSetHintBits from tqual.c
and do the full pushup in these places.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: change name of redirect_stderr?
Next
From: "Simon Riggs"
Date:
Subject: Re: Testing the async-commit patch