Re: [HACKERS] New TODO item - Mailing list pgsql-hackers

From Thomas Lockhart
Subject Re: [HACKERS] New TODO item
Date
Msg-id 3769AF66.B6F02756@alumni.caltech.edu
Whole thread Raw
In response to Re: [HACKERS] New TODO item  (Bruce Momjian <maillist@candle.pha.pa.us>)
Responses Re: [HACKERS] New TODO item
List pgsql-hackers
> > Looks to me like the parser is failing to reject this query as malformed.
> > transformIdent() is willing to take either a column name or a relation
> > name (why?), and no one upstream is rejecting the relation-name case.
> There is some reason for this that I think Thomas can tell us.

Moi? Why drag me into this? ;)

I'm not recalling why we would want to handle bare relation names in
an expression, but it does seem that a flag is being set in
transformIdent() which one could test later to verify that you have a
column. afaik this code predates my contributions, so I don't have
much insight into it. (It is true that there are a few extensions to
the SQL syntax which are holdovers from the PostQuel language, which
explains a few odd features in the parser.)

Would you prefer that we do nothing until I have a chance to research
this some more, or is someone going to dive in?
                     - Thomas

-- 
Thomas Lockhart                lockhart@alumni.caltech.edu
South Pasadena, California


pgsql-hackers by date:

Previous
From: "D'Arcy" "J.M." Cain
Date:
Subject: Re: [HACKERS] This is weird
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] tables > 1 gig