Re: pg_waldump: support decoding of WAL inside tarfile - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_waldump: support decoding of WAL inside tarfile
Date
Msg-id 3565835.1775147392@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_waldump: support decoding of WAL inside tarfile  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: pg_waldump: support decoding of WAL inside tarfile
Re: pg_waldump: support decoding of WAL inside tarfile
List pgsql-hackers
Thomas Munro <thomas.munro@gmail.com> writes:
> On Thu, Apr 2, 2026 at 2:22 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> So I think we need something like the attached, in addition
>> to what I sent before.  This just makes astreamer_tar.c use
>> the isValidTarHeader function that pg_dump already had.

> LGTM.

Pushed, thanks for reviewing!  In the event I decided to back-patch to
v18, where these fixes could protect pg_verifybackup against tar files
it can't handle.  In older branches the astreamer (nee bbstreamer)
logic only exists inside pg_basebackup, and IIUC that's not really
exposed to tar files that weren't made by our own code.  So I did
not bother with back-patching further, though it'd be possible to
do that if someone knows a scenario where it'd matter.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: pg_get__*_ddl consolidation
Next
From: Robert Haas
Date:
Subject: Re: pg_plan_advice