Re: pg_waldump: support decoding of WAL inside tarfile - Mailing list pgsql-hackers

On 4/2/26 18:29, Tom Lane wrote:
> Thomas Munro <thomas.munro@gmail.com> writes:
>> On Thu, Apr 2, 2026 at 2:22 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> So I think we need something like the attached, in addition
>>> to what I sent before.  This just makes astreamer_tar.c use
>>> the isValidTarHeader function that pg_dump already had.
> 
>> LGTM.
> 
> Pushed, thanks for reviewing!  In the event I decided to back-patch to
> v18, where these fixes could protect pg_verifybackup against tar files
> it can't handle.  In older branches the astreamer (nee bbstreamer)
> logic only exists inside pg_basebackup, and IIUC that's not really
> exposed to tar files that weren't made by our own code.  So I did
> not bother with back-patching further, though it'd be possible to
> do that if someone knows a scenario where it'd matter.
> 

It seems jay/hippopotamus failed on this, for some reason. Those two
animals are on the same host, just using different compilers. I did
update+reboot the machine this afternoon (before the test), but I don't
see why that would cause the failure.

Maybe there's something special about OpenSUSE?

-- 
Tomas Vondra