Re: [PATCH] Rebuild CHECK constraints after generated column SET EXPRESSION - Mailing list pgsql-hackers

On 02.06.26 02:41, jian he wrote:
> On Fri, May 29, 2026 at 6:58 AM Zsolt Parragi <zsolt.parragi@percona.com> wrote:
>>
>> Looks good, I have one nitpick question:
>>
>> +                       if (isnull)
>> +                               elog(WARNING, "null conbin for relation \"%s\"",
>> +                                        RelationGetRelationName(rel));
>>
>> Shouldn't this be an error instead? Most existing checks treat it as
>> an error, and that seems better to me as this shouldn't happen
>> normally?
>>
> OK.
> 
> I changed it to:
>> +                       if (isnull)
>> +                               elog(ERROR, "null conbin for relation \"%s\"",
>> +                                        RelationGetRelationName(rel));
> 
> I also slightly rephrased the commit message.

Committed with some code beautification editorialization.