Re: [PATCH] Phrase search ported to 9.6 - Mailing list pgsql-hackers

From Dmitry Ivanov
Subject Re: [PATCH] Phrase search ported to 9.6
Date
Msg-id 3434940.RE8VbBU72A@abook
Whole thread Raw
In response to Re: [PATCH] Phrase search ported to 9.6  (Artur Zakirov <a.zakirov@postgrespro.ru>)
Responses Re: [PATCH] Phrase search ported to 9.6
Re: [PATCH] Phrase search ported to 9.6
Re: [PATCH] Phrase search ported to 9.6
List pgsql-hackers
Hi, Artur

I've made an attempt to fix some of the issues you've listed, although there's
still much work to be done. I'll add some comments later.

> This function has the duplicated piece from the tsvector_setweight()
> from tsvector_op.c. You can define new function for it.

I'm not sure it's worth the trouble. IMO these functions are relatively small
and we won't benefit from extracting the duplicate code.

> These functions was removed in 9acb9007de30b3daaa9efc16763c3bc6e3e0a92d.
> It seems that tsvector_op.c was not synchronized with the master.

Got it, thanks!

--
Dmitry Ivanov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Pushdown target list below gather node (WAS Re: WIP: Upper planner pathification)
Next
From: Pavel Stehule
Date:
Subject: Re: plpgsql - DECLARE - cannot to use %TYPE or %ROWTYPE for composite types