Re: making relfilenodes 56 bits - Mailing list pgsql-hackers

From Tom Lane
Subject Re: making relfilenodes 56 bits
Date
Msg-id 339122.1664476784@sss.pgh.pa.us
Whole thread Raw
In response to Re: making relfilenodes 56 bits  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: making relfilenodes 56 bits
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Thu, Sep 29, 2022 at 10:50 AM Maxim Orlov <orlovmg@gmail.com> wrote:
>> In other words, we have 19 attributes. But tupdesc here is constructed for 18 elements:
>> tupdesc = CreateTemplateTupleDesc(18);

> I think that's a mistake. Thanks for the report.

The assertions in TupleDescInitEntry would have caught that,
if only utils/misc/pg_controldata.c had more than zero test coverage.
Seems like somebody ought to do something about that.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Question: test "aggregates" failed in 32-bit machine
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] Introduce array_shuffle() and array_sample()