Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags
Date
Msg-id 3126.1292083992@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
I wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> This broke the buildfarm on Windows, and I'm not sure of the best way to fix it.

> Hm, those symbols are already in use elsewhere in the code; I would
> assume it's just a matter of missing #includes in these particular
> files.  Where does Windows define 'em?

Ah, I have a theory: <fcntl.h>.  Seems that ancient Unix specs say
S_IRUSR etc should be defined there, rather than <sys/stat.h> which
is the modern expectation.  Count on M$ to find creative ways of being
incompatible ...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: create tablespace fails silently, or succeeds improperly
Next
From: Magnus Hagander
Date:
Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags