Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags
Date
Msg-id 2415.1292081227@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags  (Magnus Hagander <magnus@hagander.net>)
Responses Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> This broke the buildfarm on Windows, and I'm not sure of the best way to fix it.
> We currently define read and write permissions in port/win32.h
> specifically for windows. A quick-fix to just add these new ones as
> aliases won't work, because they are used in both open and umask
> calls.

Hm, those symbols are already in use elsewhere in the code; I would
assume it's just a matter of missing #includes in these particular
files.  Where does Windows define 'em?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Florian Pflug
Date:
Subject: Re: proposal: auxiliary functions for record type
Next
From: Dmitriy Igrishin
Date:
Subject: Re: proposal: auxiliary functions for record type