Re: [HACKERS] Garbled comment in postgresGetForeignJoinPaths - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Garbled comment in postgresGetForeignJoinPaths
Date
Msg-id 302.1502907403@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Garbled comment in postgresGetForeignJoinPaths  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [HACKERS] Garbled comment in postgresGetForeignJoinPaths  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Aug 16, 2017 at 12:31 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> -->  * reconstruct the row for EvalPlanQual(). Find an alternative local path
>> Should the marked line simply be deleted?  If not, what correction is
>> appropriate?

> Hmm, wow.  My first thought was that it should just say
> "reconstructing" rather than "reconstruct", but on further reading I
> think you might have the right idea.

The current text of the comment dates to commit 177c56d60, and looking at
that commit makes it pretty clear that the line I'm complaining of
belonged to the previous text; it evidently just missed getting deleted.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Atomics for heap_parallelscan_nextpage()
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] Logical replication: stuck spinlock atReplicationSlotRelease