Re: BTREE_BUILD_STATS build is broken - Mailing list pgsql-hackers

From Tom Lane
Subject Re: BTREE_BUILD_STATS build is broken
Date
Msg-id 30145.1464100280@sss.pgh.pa.us
Whole thread Raw
In response to Re: BTREE_BUILD_STATS build is broken  (Peter Geoghegan <pg@heroku.com>)
List pgsql-hackers
Peter Geoghegan <pg@heroku.com> writes:
> On Mon, May 23, 2016 at 8:09 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> (More generally, is there a better answer for that problem?)

> My unpublished parallel B-Tree index build patch will move everything
> to do with index builds into nbtsort.c.

Yeah, I was kind of wondering why tcopprot.h had anything to do with
sorting or indexing behavior at all.  It seems like relocating the
declarations would be a better long-term answer.

> Short term, I guess the best solution is to just have a pgrminclude
> directive in both files.

If we're intending to get rid of the dependency, I won't bother with
adding the other directive.  I don't believe there are any near-term
plans to run pgrminclude.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Jim Nasby
Date:
Subject: Re: Lets (not) break all the things. Was: [pgsql-advocacy] 9.6 -> 10.0
Next
From: Konstantin Knizhnik
Date:
Subject: Re: Inheritance