Re: pg_upgrade: Pass -j down to vacuumdb - Mailing list pgsql-hackers

From Jesper Pedersen
Subject Re: pg_upgrade: Pass -j down to vacuumdb
Date
Msg-id 2dc5eaeb-e60d-2a16-696e-7b4d3d3548cb@redhat.com
Whole thread Raw
In response to Re: pg_upgrade: Pass -j down to vacuumdb  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: pg_upgrade: Pass -j down to vacuumdb  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Hi,

On 12/29/18 10:03 AM, Peter Eisentraut wrote:
> On 21/12/2018 11:12, Jesper Pedersen wrote:
>> Here is a patch that passes the -j option from pg_upgrade down to
>> vacuumdb if supported.
> 
> It's not clear to me that that is what is usually wanted.
> 
> The point of the post-upgrade analyze script is specifically to do the
> analyze in a gentle fashion.  Mixing in parallelism would seem to defeat
> that a bit.
> 

Well, that really depends. The user passed -j to pg_upgrade in order for 
the upgrade to happen faster, so maybe they would expect, as I would, 
that the ANALYZE phase would happen in parallel too.

At least there should be a "notice" about what the script will do in 
this case.

Best regards,
  Jesper


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Is MinMaxExpr really leakproof?
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] Time to change pg_regress diffs to unified by default?