On 2019-02-20 07:20, Tsunakawa, Takayuki wrote:
> From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
>> Hm. Putting a list header for a purely-local data structure into shared
>> memory seems quite ugly. Isn't there a better place to keep that?
>
> Agreed. I put it in the global variable.
I think there is agreement on the principles of this patch. Perhaps it
could be polished a bit.
Your changes in LOCALLOCK still refer to PGPROC, from your first version
of the patch.
I think the reordering of struct members could be done as a separate
preliminary patch.
Some more documentation in the comment before dlist_head LocalLocks to
explain this whole mechanism would be nice.
You posted a link to some performance numbers, but I didn't see the test
setup explained there. I'd like to get some more information on this
impact of this. Is there an effect with 100 tables, or do you need 100000?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
