Re: psql :: support for \ev viewname and \sv viewname - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: psql :: support for \ev viewname and \sv viewname
Date
Msg-id 2b196506-e678-d22d-4cdb-ace77a884408@2ndquadrant.com
Whole thread Raw
In response to Re: psql :: support for \ev viewname and \sv viewname  (Dean Rasheed <dean.a.rasheed@gmail.com>)
Responses Re: psql :: support for \ev viewname and \sv viewname  (Dean Rasheed <dean.a.rasheed@gmail.com>)
List pgsql-hackers

On 5/3/16 3:10 PM, Dean Rasheed wrote:
> On 3 May 2016 at 16:52, Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>> I would change appendReloptionsArrayAH() to a function and keep AH as the
>> first argument (similar to other functions that take such a handle).
>
> I can understand changing it to a function, but I don't think AH
> should be the first argument. All other append*() functions that
> append to a buffer have the buffer as the first argument, including
> the appendStringLiteralAH() macro on which this is based.

Well, all the functions that take archive handles have that as the first 
argument, so how do we consolidate that?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: pg9.6 segfault using simple query (related to use fk for join estimates)
Next
From: Michael Paquier
Date:
Subject: Re: pg_xlog -> pg_xjournal?