Re: Distinguish publication exclusions in object addresses - Mailing list pgsql-hackers

> On Sep 16, 2026, at 13:50, Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> --
> With Regards,
> Amit Kapila.
> <v4-0001-Distinguish-publication-exclusions-in-object-addr.patch>

V4 overall looks sold to me. Just a couple of small comments:

1
```
-- No entry of either kind.  testpub_default publishes nothing.
SELECT pg_get_object_address('publication excluded relation',
                             '{public, testpub_tbl1}', '{testpub_default}');
ERROR:  publication relation "testpub_tbl1" in publication "testpub_default" does not exist
```

For this new test, the error message is a little surprising to me. Since the requested object type is "publication
excludedrelation", I would expect the error message to say something like: 
```
publication excluded relation "testpub_tbl1" in publication "testpub_default" does not exist
```

2
```
+    if (objtype == OBJECT_PUBLICATION_EXCLUDED_REL && !isexcept)
+        ereport(ERROR,
+                (errcode(ERRCODE_WRONG_OBJECT_TYPE),
+                 errmsg("\"%s\" is not an excluded relation of publication \"%s\"",
+                        RelationGetRelationName(relation), pubname)));
+    else if (objtype == OBJECT_PUBLICATION_REL && isexcept)
+        ereport(ERROR,
+                (errcode(ERRCODE_WRONG_OBJECT_TYPE),
+                 errmsg("\"%s\" is not a published relation of publication \"%s\"",
+                        RelationGetRelationName(relation), pubname)));
```

Nitpick: with the modern ereport() style, the extra parentheses around errcode() and errmsg() are no longer needed.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/