Re: [HACKERS] Upgrading postmaster's log messages about bind/listen errors - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Upgrading postmaster's log messages about bind/listen errors
Date
Msg-id 29761.1489510209@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Upgrading postmaster's log messages about bind/listen errors  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] Upgrading postmaster's log messages about bind/listenerrors  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
I wrote:
>> I think that what would actually be of some use nowadays is a LOG-level
>> message emitted if the wraparound *isn't* activated immediately at start.
>> But otherwise, we should follow the rule that silence is golden.

> Concretely, how about the attached?  It preserves the original
> "protections are now enabled" message at LOG level, but emits it only
> when oldestOffsetKnown becomes true *after* startup.  Meanwhile, if
> oldestOffsetKnown is still not true at the conclusion of TrimMultiXact,
> then it emits a new LOG message about "protections are not active".

I realized that the second of these is not necessary because it's
redundant with the message about "MultiXact member wraparound protections
are disabled because oldest checkpointed MultiXact %u does not exist on
disk".  Pushed without that.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] Gather Merge
Next
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] Patch: Write Amplification Reduction Method (WARM)