Re: Win32 timezone matching - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Win32 timezone matching
Date
Msg-id 29734.1270594132@sss.pgh.pa.us
Whole thread Raw
In response to Re: Win32 timezone matching  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Win32 timezone matching  (Magnus Hagander <magnus@hagander.net>)
Re: Win32 timezone matching  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> On Wed, Apr 7, 2010 at 00:02, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Oh, another thought here: what is the effect of the combination of this
>> with your other proposal to add more timezones to the list?

> [ none ]

Ah, right, I hadn't looked closely at the logic before.  Still have
two comments though:

* There are other error conditions that cause "break"s in that loop.
Should we change the others?

* There is a comment at the head of win32_tzmap[] explaining where the
data came from; you need to update that.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pg_filedump strangeness
Next
From: "David E. Wheeler"
Date:
Subject: Use UNKNOWN with PL/Perl spi_prepare()?