Re: [PATCHES] Fixes gram.y - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCHES] Fixes gram.y
Date
Msg-id 29701.1016556884@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCHES] Fixes gram.y  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [PATCHES] Fixes gram.y  (Bruce Momjian <pgman@candle.pha.pa.us>)
Re: [PATCHES] Fixes gram.y  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Peter Eisentraut wrote:
>> There is a standard for this.  CREATE DOMAIN shows CREATE DOMAIN.

> OK, CVS changed to emit CREATE DOMAIN.

What's standard about it?  I count 9 existing statements that use
"CREATE", vs 4 that use "CREATE xxx".  (And of those four, CREATE
VERSION is dead code...)  The closest existing statement, CREATE
TYPE, emits "CREATE".

Plain "CREATE" seems like the conforming choice, unless we'd like
to do a wholesale revision of existing command tags.  Which is
not necessarily an unreasonable thing to do.  But just making CREATE
DOMAIN emit "CREATE DOMAIN" isn't improving consistency at all.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [PATCHES] Fixes gram.y
Next
From: Bruce Momjian
Date:
Subject: Re: [PATCHES] Fixes gram.y