Re: [PATCHES] Fixes gram.y - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [PATCHES] Fixes gram.y
Date
Msg-id 200203191656.g2JGuNc06581@candle.pha.pa.us
Whole thread Raw
In response to Re: [PATCHES] Fixes gram.y  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Peter Eisentraut wrote:
> >> There is a standard for this.  CREATE DOMAIN shows CREATE DOMAIN.
>
> > OK, CVS changed to emit CREATE DOMAIN.
>
> What's standard about it?  I count 9 existing statements that use
> "CREATE", vs 4 that use "CREATE xxx".  (And of those four, CREATE
> VERSION is dead code...)  The closest existing statement, CREATE
> TYPE, emits "CREATE".
>
> Plain "CREATE" seems like the conforming choice, unless we'd like
> to do a wholesale revision of existing command tags.  Which is
> not necessarily an unreasonable thing to do.  But just making CREATE
> DOMAIN emit "CREATE DOMAIN" isn't improving consistency at all.

I assumed Peter meant some kind of ANSI SQL standard, but I am kind of
lost how they define that level of detail in the standard.  I agree a
wholesale cleanup there would be a good idea.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCHES] Fixes gram.y
Next
From: Peter Eisentraut
Date:
Subject: Re: [PATCHES] Fixes gram.y