Re: bug in SignalSomeChildren - Mailing list pgsql-hackers

From Tom Lane
Subject Re: bug in SignalSomeChildren
Date
Msg-id 29695.1292599650@sss.pgh.pa.us
Whole thread Raw
In response to Re: bug in SignalSomeChildren  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: bug in SignalSomeChildren  (Robert Haas <robertmhaas@gmail.com>)
Re: bug in SignalSomeChildren  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> I think the attached might be a little tidier.  Thoughts?

I'm not really thrilled at the idea of calling
IsPostmasterChildWalSender for every child whether or not it will have
any impact on the decision.  That involves touching shared memory which
can be rather expensive (see previous discussions about shared cache
lines and so forth).

The existing coding is pretty ugly, I agree.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: patch: remove redundant code from pl_exec.c
Next
From: David Fetter
Date:
Subject: Re: plperlu problem with utf8