I've applied version 0.58 of the patch with a lot of further
editorializing. I feel fairly confident now in the code that interfaces
between tsearch and the rest of the system, but a lot of the
lowest-level "guts" of tsearch (mainly in src/backend/tsearch/*.c and
src/backend/utils/adt/ts*.c) left my eyes glazing over. Perhaps someone
else can make an extra review pass over that stuff.
I am quite confident that this commit broke the MSVC build, which seems
to need to know individually about each shared library ... Magnus,
can you do something about that? We'll see what other portability
problems emerge from the buildfarm.
The main thing that is lacking at the moment is documentation. The
stuff Bruce has been working on will be good introductory material,
but we've got basically zip in reference material. I'll do some work
on that over the next couple of days, but there's probably room for
more hands.
Also, we need to decide what to do with contrib/tsearch2, which is
currently DOA because of conflicts with the new core code. We could
either rip it out entirely, or try to convert it into a compatibility
package. In view of the renamings of functions we agreed to do, I
think there is some scope for a compatibility package, but I have no
time to work on that.
This is, by a wide margin, the largest single patch ever to hit the
Postgres CVS tree. Congratulations to Oleg and Teodor on seeing
it through!
regards, tom lane
