Re: Syntax got translated - Mailing list pgsql-bugs

From Tom Lane
Subject Re: Syntax got translated
Date
Msg-id 28897.1329771354@sss.pgh.pa.us
Whole thread Raw
In response to Re: Syntax got translated  (Guillaume Lelarge <guillaume@lelarge.info>)
Responses Re: Syntax got translated
Re: Syntax got translated
List pgsql-bugs
Guillaume Lelarge <guillaume@lelarge.info> writes:
> On Mon, 20 Feb 2012 14:15:34 -0300, Alvaro Herrera
> <alvherre@commandprompt.com> wrote:
>> Excerpts from Susanne Ebrecht's message of sáb feb 18 18:11:54 -0300
>>> I think that the constraint keyword "DEFAULT" should not be translated
>>> here.

> I don't see why the modifiers shouldn't be translatable. It's not as if
> they were intended to be copied and pasted in a query. They are here to
> help the user understand the different modifiers in each column.

> -1 to get rid of the translations.

It seems to boil down to whether you think the "Modifiers" column
contains SQL, or a textual description of the column's properties.
I could go either way on that, but I notice that the existing code
is in the habit of truncating the default expression at 128 characters.
If we want to decide that we're printing real, copy-and-pastable SQL,
that seems like a bad idea.  On the other hand, if we're printing
informational text, it's not an unreasonable thing.

            regards, tom lane

pgsql-bugs by date:

Previous
From: Susanne Ebrecht
Date:
Subject: Re: Syntax got translated
Next
From: Guillaume Lelarge
Date:
Subject: Re: Syntax got translated