Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x
Date
Msg-id 28752.1496238931@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] [PATCH] relocation truncated to fit: citus buildfailure on s390x  (Christoph Berg <myon@debian.org>)
Responses Re: [HACKERS] [PATCH] relocation truncated to fit: citus buildfailure on s390x  (Christoph Berg <myon@debian.org>)
List pgsql-hackers
Christoph Berg <myon@debian.org> writes:
> Re: Tom Lane 2017-05-30 <1564.1496176732@sss.pgh.pa.us>
>> It'd be interesting if people could gather similar numbers on other
>> platforms of more real-world relevance, such as ppc64.  But based on
>> this small sample, I wouldn't object to just going to -fPIC across
>> the board.

> [ more numbers ]

OK, this looks good to me.  Just to make sure everyone's on the
same page, what I propose to do is simplify all our platform-specific
Makefiles that use either -fpic or -fPIC to use -fPIC unconditionally.
This affects the netbsd, linux, and openbsd ports.  Looks like we should
also change the example link commands in dfunc.sgml.

Next question: should we back-patch this change, or just do it in HEAD?

            regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] Create subscription with `create_slot=false` andincorrect slot name
Next
From: Dilip Kumar
Date:
Subject: Re: [HACKERS] Error while creating subscription when server isrunning in single user mode