Re: remove flatfiles.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: remove flatfiles.c
Date
Msg-id 28748.1251923826@sss.pgh.pa.us
Whole thread Raw
In response to Re: remove flatfiles.c  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: remove flatfiles.c
List pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Another weird consequence of this is that it bails out if it finds a
> tuple larger than it can fit in one of the earlier pages; if there's
> dead space to be compacted before that, it's not compacted.

I don't find a lot wrong with that.  The code defines its purpose as
being to shorten the table file length.  Once it hits a page that
can't be emptied, it cannot shorten the file any further, so why
shouldn't it stop?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: community decision-making & 8.5
Next
From: Alvaro Herrera
Date:
Subject: Re: clang's static checker report.