Remove redundant extra_desc info for enum GUC variables? - Mailing list pgsql-hackers

From Tom Lane
Subject Remove redundant extra_desc info for enum GUC variables?
Date
Msg-id 28724.1211831808@sss.pgh.pa.us
Whole thread Raw
Responses Re: Remove redundant extra_desc info for enum GUC variables?  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Most of the GUC variables that have been converted to enums have an
extra_desc string that lists the valid values --- in HEAD, try
SELECT name,extra_desc,enumvals from pg_settings where vartype = 'enum';

ISTM this is just about 100% redundant with the enumvals column and
should be removed to reduce translation and maintenance effort.
Any objections?

One point of interest is that for client_min_messages and
log_min_messages, the ordering of the values has significance, and it's
different for the two cases.  The enum patch has lost that info by
trying to use the same auxiliary list for both variables.  But having
two lists doesn't seem like an excessive amount of overhead.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Euler Taveira de Oliveira
Date:
Subject: Re: Help with new contrib
Next
From: Jeff Davis
Date:
Subject: Re: Proposal: temporal extension "period" data type