Re: pgsql/src/include parser/parse_coerce.h catalo ... - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql/src/include parser/parse_coerce.h catalo ...
Date
Msg-id 28594.1001808223@sss.pgh.pa.us
Whole thread Raw
In response to pgsql/src/include parser/parse_coerce.h catalo ...  (inoue@postgresql.org)
List pgsql-committers
inoue@postgresql.org writes:
> Modified files:
>     src/include/parser: parse_coerce.h
>     src/include/catalog: pg_operator.h
> Log message:
>     Allow comparison between xid and xid, int.

I do not think it's a good idea to define xid and int as
binary-compatible.  If it is a good idea then you did it wrong
--- IS_BINARY_COMPATIBLE needs to test for both directions.

But what I'd suggest is to undo the IS_BINARY_COMPATIBLE change
and instead add another pg_operator entry that accepts xid = int4,
mapping it to xideq.  That gets the job done without opening up
a morass of binary-compatibility issues.

            regards, tom lane

pgsql-committers by date:

Previous
From: tgl@postgresql.org
Date:
Subject: pgsql/src/backend/access/nbtree nbtinsert.c
Next
From: momjian@postgresql.org
Date:
Subject: pgsql/ oc/TODO rc/backend/storage/lmgr/deadloc ...