Re: [RFC] Extend namespace of valid guc names - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [RFC] Extend namespace of valid guc names
Date
Msg-id 28392.1378476803@sss.pgh.pa.us
Whole thread Raw
In response to Re: [RFC] Extend namespace of valid guc names  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: [RFC] Extend namespace of valid guc names
List pgsql-hackers
Andres Freund <andres@2ndquadrant.com> writes:
> On 2013-02-25 21:13:25 -0500, Tom Lane wrote:
>>> b) allow variables to start with a digit from the second level onwards.

>> That seems like a seriously bad idea.  I note that SET does *not* allow
>> this;

> Hm. One thing about this is that we currently allow something silly as:
> SET "1"."1bar""blub" = 3;

> So I'd like to either restrict SET here or allow the same for guc-file.l
> parsed GUCs. Any opinions?

Well, if you feel an absolute compulsion to make them consistent, I'd
go with making SET disallow creation of variables with names the file
parser wouldn't recognize.  But why is it such a bad thing if SET can
do that?  The whole reason we allow SET to create new variables at all
is that the universe of things you can have as session-local values is
larger than the set of parameters that are allowed in postgresql.conf.
So I'm missing why we need such a restriction.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [RFC] Extend namespace of valid guc names
Next
From: Tom Lane
Date:
Subject: Re: get rid of SQL_ASCII?