Re: use GUC for cmdline - Mailing list pgsql-patches

From Tom Lane
Subject Re: use GUC for cmdline
Date
Msg-id 28267.993167444@sss.pgh.pa.us
Whole thread Raw
In response to Re: use GUC for cmdline  (Marko Kreen <marko@l-t.ee>)
Responses Re: use GUC for cmdline  (Marko Kreen <marko@l-t.ee>)
List pgsql-patches
Marko Kreen <marko@l-t.ee> writes:
>> This seems like an appropriate fix.  I would recommend doing the same
>> with all the option switch settings that are protected with "if
>> (secure)".  This is not a hack: essentially it says we will treat
>> options passed to the postmaster with -o as postmaster-time options.

> -                if (secure)
> -                    SetConfigOption("shared_buffers", optarg, ctx, true);
> +                SetConfigOption("shared_buffers", optarg, secure_ctx, true);

Uh, removing the security checks is NOT what I had in mind.  Wasn't
my example clear enough?

            regards, tom lane

pgsql-patches by date:

Previous
From: Marko Kreen
Date:
Subject: Re: use GUC for cmdline
Next
From: Marko Kreen
Date:
Subject: Re: use GUC for cmdline