Re: Fixing parallel make of libpq - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fixing parallel make of libpq
Date
Msg-id 28209.1578668900@sss.pgh.pa.us
Whole thread Raw
In response to Re: Fixing parallel make of libpq  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: Fixing parallel make of libpq
List pgsql-hackers
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2020-01-09 15:17, Tom Lane wrote:
>> 1) Changing from an "|"-style dependency to a plain dependency seems
>> like a semantics change.  I've never been totally clear on the
>> difference though.  I think Peter introduced our use of the "|" style,
>> so maybe he can comment.

> If you have a phony target as a prerequisite of a real-file target, you 
> should make that an order-only ("|") prerequisite.  Otherwise the 
> real-file target rules will *always* be run, on account of the phony 
> target prerequisite.

OK, got that.  But that doesn't directly answer the question of whether
it's wrong to use a phony target as an order-only prerequisite of
another phony target.  Grepping around for other possible issues,
I see that you recently added

update-unicode: | submake-generated-headers submake-libpgport
    $(MAKE) -C src/common/unicode $@
    $(MAKE) -C contrib/unaccent $@

Doesn't that also have parallel-make hazards, if libpq does?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Assert failure due to "drop schema pg_temp_3 cascade" for temporary tables and \d+ is not showing any info after drooping temp table schema
Next
From: Tom Lane
Date:
Subject: Re: Avoid full GIN index scan when possible