Re: vacuum analyze fails: ERROR: Unable to locate type oid 2230924 in catalog - Mailing list pgsql-hackers

From Tom Lane
Subject Re: vacuum analyze fails: ERROR: Unable to locate type oid 2230924 in catalog
Date
Msg-id 28078.983248764@sss.pgh.pa.us
Whole thread Raw
In response to Re: vacuum analyze fails: ERROR: Unable to locate type oid 2230924 in catalog  (Tatsuo Ishii <t-ishii@sra.co.jp>)
Responses Re: vacuum analyze fails: ERROR: Unable to locate type oid 2230924 in catalog  (Tatsuo Ishii <t-ishii@sra.co.jp>)
List pgsql-hackers
Tatsuo Ishii <t-ishii@sra.co.jp> writes:
> I thought "typeidIsValid(targetTypeId) == false" is better than
> "!typeidIsValid(targetTypeId)"?

I've always thought that "== true" and "== false" on something that's
already a boolean are not good style.  It's a matter of taste I suppose.
But note that the existing calls on typeidIsValid are coded that way...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Re[2]: Re: [PATCHES] A patch for xlog.c
Next
From: Tatsuo Ishii
Date:
Subject: Re: vacuum analyze fails: ERROR: Unable to locate type oid 2230924 in catalog