Re: Extensible executor nodes for preparation of SQL/MED - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Extensible executor nodes for preparation of SQL/MED
Date
Msg-id 2673.1289932130@sss.pgh.pa.us
Whole thread Raw
In response to Re: Extensible executor nodes for preparation of SQL/MED  (Itagaki Takahiro <itagaki.takahiro@gmail.com>)
Responses Re: Extensible executor nodes for preparation of SQL/MED
List pgsql-hackers
Itagaki Takahiro <itagaki.takahiro@gmail.com> writes:
> Here is a WIP patch to extensible executor nodes.

I am of the opinion that a run-time-extensible set of plan node types
is merest fantasy.  We will never have that, so putting in place 5%
of the infrastructure for it is a waste of time and notational
complexity.

I would support replacing the switch in ExecProcNode with a
function-pointer call on performance grounds.  The implementation of
that IMHO should match what's done for runtime expression state nodes:
set up the function pointer in the InitNode function that creates the
executor state node.  But the rest of this patch, particularly the
addition of vtables to plan nodes, is pointless complication.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: GiST insert algorithm rewrite
Next
From: Robert Haas
Date:
Subject: Re: unlogged tables