Re: assume availability of "inline" keyword - Mailing list pgsql-hackers

From Tom Lane
Subject Re: assume availability of "inline" keyword
Date
Msg-id 2670103.1771528773@sss.pgh.pa.us
Whole thread Raw
In response to assume availability of "inline" keyword  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: assume availability of "inline" keyword
List pgsql-hackers
Nathan Bossart <nathandbossart@gmail.com> writes:
> I noticed some code that uses __inline__ (which IIUC is a gcc extension) as
> well as a related configure check.  "inline" was first added to C99, and we
> now require C11, so we can just assume it's there, right?  FWIW it looks
> like meson builds don't bother checking this.

All those usages are guarded by

#if defined(__GNUC__) || defined(__INTEL_COMPILER)

so we are only concerned with gcc-alikes, which reduces the risks
of trouble.  However, I have a vague recollection that it is/was
possible to put gcc in a mode where it only takes __inline__
not inline.  This is likely something you get from -std=c90 or
thereabouts, which would be irrelevant now.  But I'd suggest
checking it's okay under -std=c11 (not gnu11), just to be sure.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Hash aggregate collisions cause excessive spilling
Next
From: Andres Freund
Date:
Subject: Re: Hash aggregate collisions cause excessive spilling